Update jsx-no-hardcoded-content to handle ternary and logical expressions#488
Open
Update jsx-no-hardcoded-content to handle ternary and logical expressions#488
Conversation
Member
Author
|
/snapit |
Member
Author
|
/snapit |
BPScott
approved these changes
Jan 8, 2026
Member
BPScott
left a comment
BPScott
left a comment
There was a problem hiding this comment.
Code changes seem good. We should fix the publishing to use OIDC before we merge this, so we can get the snapit back to working correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
@shopify/jsx-no-hardcoded-contentESLint rule to detect hardcoded strings within conditional (ternary) and logical expressions (&&,||). Previously, expressions like the following were not flagged:Changes
isInvalidContentto recursively checkConditionalExpressionandLogicalExpression.