Reveal schema when hovering on associations#654
Open
kumarpit wants to merge 1 commit intoShopify:mainfrom
Open
Reveal schema when hovering on associations#654kumarpit wants to merge 1 commit intoShopify:mainfrom
kumarpit wants to merge 1 commit intoShopify:mainfrom
Conversation
vinistock
previously approved these changes
Nov 11, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
vinistock
reviewed
Nov 11, 2025
|
|
||
| return unless result | ||
|
|
||
| generate_column_content(result[:name]) |
Member
There was a problem hiding this comment.
Adding this as is here works, but it means that any hover on associations needs two round trips to the server to pull information.
Instead of doing that, could we include the required information as part of the association_target response and then extract what's needed to generate the hover?
That way we get all of the data in a single request.
Contributor
Author
There was a problem hiding this comment.
Ah, thats a good point! I'll look into that and let you know, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359
Add schema, indexes, and foreign key constraints information when hovering an association table.
Demo (VSCode)
ruby-lsp-assoc-schema-demo-vscode.mov