Skip to content

Comments

Mirror source tree for adapter headers#260

Draft
hgangwar wants to merge 1 commit intoSCOREC:developfrom
hgangwar:mirror_src
Draft

Mirror source tree for adapter headers#260
hgangwar wants to merge 1 commit intoSCOREC:developfrom
hgangwar:mirror_src

Conversation

@hgangwar
Copy link

Install adapter headers via DIRECTORY install.

Changes

  • Defined ADAPTER_HEADERS.
  • Installed headers from ADAPTER_HEADERS into their respective directories.
  • Included create_field.h in examples for external-usage-example usage testing.

@hgangwar
Copy link
Author

@jacobmerson

@jacobmerson
Copy link
Collaborator

We had a breif discussion offline. We are going to investigate converting our header definitions over to FILE_SETS which should maintain the structure.

https://cmake.org/cmake/help/latest/command/install.html#id5

This approach looks like it may also enable us to set up targets that check that the header files can be correctly included, which would be a nice test to include to our CI/CD testing.

https://cmake.org/cmake/help/latest/prop_tgt/VERIFY_INTERFACE_HEADER_SETS.html#prop_tgt:VERIFY_INTERFACE_HEADER_SETS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants