Skip to content

Conversation

@davidkna-sap
Copy link
Member

@davidkna-sap davidkna-sap commented Jan 12, 2026

Context

SAP/cloud-sdk-java-backlog#ISSUENUMBER.

This changes the OAuth2 token request parameter from refresh_token to refresh_expiry for named user current with app_tid to disable refresh token issuance.

The documented approach for disabling refresh token issuance is refresh_expiry=0, but currently refresh_token=0 is set instead. The issue that lead to the workaround being added also talks about refresh_expiry and the API documentation only mentions refresh_expiry.

Feature scope:

  • Update parameter being set
  • Update existing unit test

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@thisisjustinm
Copy link
Member

Hi @davidkna-sap, small query, with which version will this change be available?

Copy link
Member

@rpanackal rpanackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisjustinm
Copy link
Member

Hi @davidkna-sap, small query, with which version will this change be available?

Just rechecking :) @jjtang1985 @rpanackal @davidkna-sap

@MatKuhr
Copy link
Member

MatKuhr commented Jan 23, 2026

I also checked again, it seems I copy/pasted the parameter from the wrong teams chat when adding this originally, my bad 😧

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants