Add Insufficient Permissions Screen #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elysseaa
commented
Nov 7, 2025
elysseaa
commented
- Follows structure of InsufficientPermissions.kt
- Can be used for both Attendance and Merchandise Screens
- Uses inline styles + stylesheet
- Closes Merch screen - Permission Denied #14 Attendance Screen - Permission denied #10
- Follows structure of InsufficientPermissions.kt - Can be used for both Attendance and Merchandise Screens - Uses inline styles + stylesheet
jvogt23
requested changes
Dec 23, 2025
Collaborator
jvogt23
left a comment
jvogt23
left a comment
There was a problem hiding this comment.
Need to look at UI against existing UI to be sure that everything looks good visually on both iOS and Android. Requested a couple of changes relevant for styling and some clarifying questions
| <Text style={{ fontSize: 25, marginVertical: 20 }}>Required Permissions</Text> | ||
| <PermissionDetailsList permissions={missingPermissions} hasPermission={false}/> | ||
| <PermissionDetailsList permissions={requiredPermissions} hasPermission={true}/> | ||
| <View style={{ alignItems:'flex-end', marginVertical: 20 }}> |
Collaborator
There was a problem hiding this comment.
Replace inline styles with a style sheet - Current ESLint settings require stylesheet for readability
| <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}> | ||
| <View style={styles.modalView}> | ||
| <Text style={{ fontSize: 25, marginVertical: 20 }}>Required Permissions</Text> | ||
| <PermissionDetailsList permissions={missingPermissions} hasPermission={false}/> |
Collaborator
There was a problem hiding this comment.
Why are all requiredPermissions shown with hasPermission=true?
Is the list of requiredPermissions the set of permissions needed for a screen which the user has? Clarification or a name change may be needed for this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.