removed duplicate Player:IsFriendsWith

[rileylorgelly]

Changes

removed duplicate of Player:IsFriendsWith, and added a deprecation message to the other.

Checks

By submitting your pull request for review, you agree to the following:

• This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
• I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
• To the best of my knowledge, all proposed changes are accurate.

[github-actions]

Hi @rileylorgelly, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

[IgnisRBX]

Hi @rileylorgelly ,
Thanks for the contribution. This is actually a result of the Engine API docs redesign that happened last December or so, where we now show all methods, including deprecated ones that were "hidden" by default in the past. This means that items like Player:IsFriendsWith() and Player:isFriendsWith() will both appear in the docs, because technically both can still be used (although Player:IsFriendsWithAsync() should obviously be used instead of either deprecated method).

Basically, this is just part of how the API docs appear now, and we can't manually remove the deprecated items. Hope that clarifies why you're seeing items that you probably didn't see before the redesign.

[IgnisRBX]

I will also, in a separate PR, add better deprecation notes to both of the legacy methods to indicate that Player:IsFriendsWithAsync() should be used in favor. :)