Skip to content

upgrades tiff to tiff6 not tiff5#718

Open
tclose wants to merge 1 commit intomasterfrom
tiff-upgrade
Open

upgrades tiff to tiff6 not tiff5#718
tclose wants to merge 1 commit intomasterfrom
tiff-upgrade

Conversation

@tclose
Copy link
Collaborator

@tclose tclose commented Mar 12, 2026

Upgrades tiff5 to tiff6

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates a core dependency for MRtrix3 installations within Neurodocker templates. The change specifically targets the mrtrix3.yaml template, ensuring that the build process utilizes libtiff6 instead of the older libtiff5. This upgrade aims to keep the dependency stack current and potentially benefit from improvements or bug fixes in the newer library version.

Highlights

  • Dependency Upgrade: The libtiff dependency in neurodocker/templates/mrtrix3.yaml has been upgraded from version 5 to version 6. This ensures that MRtrix3 installations leverage the latest stable version of the TIFF library.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • neurodocker/templates/mrtrix3.yaml
    • Updated the libtiff dependency from version 5 to version 6.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the libtiff dependency from version 5 to 6 for apt-based installations of mrtrix3 from binaries. While this is necessary for newer operating systems like Ubuntu 22.04, it will break compatibility for users on older but still common systems like Ubuntu 20.04. My review includes a suggestion to add a comment to the code to document this important change in platform support.

- curl
- libpng16-16
- libtiff5
- libtiff6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Upgrading to libtiff6 is necessary for newer Debian-based systems (e.g., Ubuntu 22.04), but it drops support for older LTS releases like Ubuntu 20.04 where only libtiff5 is available. This change in supported platforms is significant. To aid future maintenance, please add a comment clarifying the targeted distributions for this dependency.

-   libtiff6  # For Debian >= 11, Ubuntu >= 22.04. Older releases require libtiff5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant