Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates a core dependency for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the libtiff dependency from version 5 to 6 for apt-based installations of mrtrix3 from binaries. While this is necessary for newer operating systems like Ubuntu 22.04, it will break compatibility for users on older but still common systems like Ubuntu 20.04. My review includes a suggestion to add a comment to the code to document this important change in platform support.
| - curl | ||
| - libpng16-16 | ||
| - libtiff5 | ||
| - libtiff6 |
There was a problem hiding this comment.
Upgrading to libtiff6 is necessary for newer Debian-based systems (e.g., Ubuntu 22.04), but it drops support for older LTS releases like Ubuntu 20.04 where only libtiff5 is available. This change in supported platforms is significant. To aid future maintenance, please add a comment clarifying the targeted distributions for this dependency.
- libtiff6 # For Debian >= 11, Ubuntu >= 22.04. Older releases require libtiff5.
Upgrades tiff5 to tiff6