Skip to content

MOD-14130 Fix SVE benchmark compilation bug on aarch64#912

Open
ofiryanai wants to merge 1 commit intomainfrom
fix-bm-sve2
Open

MOD-14130 Fix SVE benchmark compilation bug on aarch64#912
ofiryanai wants to merge 1 commit intomainfrom
fix-bm-sve2

Conversation

@ofiryanai
Copy link
Collaborator

@ofiryanai ofiryanai commented Feb 19, 2026

Problem

Copy-paste bug in benchmark files causes compilation errors on aarch64 when OPT_SVE is defined but OPT_SVE2 is not.

The #ifdef OPT_SVE blocks incorrectly reference sve2_supported (which is only defined in the OPT_SVE2 block) instead of sve_supported.

Affected Files

  • tests/benchmark/spaces_benchmarks/bm_spaces_uint8.cpp (lines 52-53)
  • tests/benchmark/spaces_benchmarks/bm_spaces_int8.cpp (lines 52-53)

Fix

In both files, inside the #ifdef OPT_SVE block, change sve2_supported to sve_supported.

Jira

https://redislabs.atlassian.net/browse/MOD-14130


Pull Request opened by Augment Code with guidance from the PR author


Note

Low Risk
Small benchmark-only change that only affects feature gating for SVE on aarch64, with no impact on production code paths.

Overview
Fixes a copy-paste error in bm_spaces_int8.cpp and bm_spaces_uint8.cpp where the OPT_SVE benchmark registration incorrectly gated SVE benchmarks on sve2_supported instead of sve_supported.

This prevents aarch64 benchmark builds from failing (undefined sve2_supported) and ensures SVE benchmarks are enabled/disabled based on the correct CPU capability check.

Written by Cursor Bugbot for commit 6341064. This will update automatically on new commits. Configure here.

In the OPT_SVE blocks, the code incorrectly referenced sve2_supported
(only defined in OPT_SVE2 block) instead of sve_supported, causing
compilation errors when OPT_SVE is defined but OPT_SVE2 is not.
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (a68ba7d) to head (6341064).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files         129      129           
  Lines        7500     7500           
=======================================
  Hits         7282     7282           
  Misses        218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments