MOD-14130 Fix SVE benchmark compilation bug on aarch64#912
Open
MOD-14130 Fix SVE benchmark compilation bug on aarch64#912
Conversation
In the OPT_SVE blocks, the code incorrectly referenced sve2_supported (only defined in OPT_SVE2 block) instead of sve_supported, causing compilation errors when OPT_SVE is defined but OPT_SVE2 is not.
meiravgri
approved these changes
Feb 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 129 129
Lines 7500 7500
=======================================
Hits 7282 7282
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Copy-paste bug in benchmark files causes compilation errors on aarch64 when
OPT_SVEis defined butOPT_SVE2is not.The
#ifdef OPT_SVEblocks incorrectly referencesve2_supported(which is only defined in theOPT_SVE2block) instead ofsve_supported.Affected Files
tests/benchmark/spaces_benchmarks/bm_spaces_uint8.cpp(lines 52-53)tests/benchmark/spaces_benchmarks/bm_spaces_int8.cpp(lines 52-53)Fix
In both files, inside the
#ifdef OPT_SVEblock, changesve2_supportedtosve_supported.Jira
https://redislabs.atlassian.net/browse/MOD-14130
Pull Request opened by Augment Code with guidance from the PR author
Note
Low Risk
Small benchmark-only change that only affects feature gating for SVE on aarch64, with no impact on production code paths.
Overview
Fixes a copy-paste error in
bm_spaces_int8.cppandbm_spaces_uint8.cppwhere theOPT_SVEbenchmark registration incorrectly gated SVE benchmarks onsve2_supportedinstead ofsve_supported.This prevents aarch64 benchmark builds from failing (undefined
sve2_supported) and ensures SVE benchmarks are enabled/disabled based on the correct CPU capability check.Written by Cursor Bugbot for commit 6341064. This will update automatically on new commits. Configure here.