fixed netlist generation and file structure for pcells#77
Open
adityakak27 wants to merge 5 commits intoReaLLMASIC:mainfrom
Open
fixed netlist generation and file structure for pcells#77adityakak27 wants to merge 5 commits intoReaLLMASIC:mainfrom
adityakak27 wants to merge 5 commits intoReaLLMASIC:mainfrom
Conversation
Contributor
adityakak27
commented
Feb 2, 2026
- changes made in PR 76 have been fixed, naming of netlist obj has been reverted to match original naming and avoid breaking other stuff
- duplicates from ATLAS folder have been removed, only the pcells in blocks/elementary/<pcell_name> exist now, and function as intended. same for evaluator box.
- TODO: opamp placement to still be decided, kept in ATLAS/ for now
…ll elementary pcells are now fully working and in their respective folders
Contributor
|
Same comment as before: This is a good cleanup of the existing code. Please commit the same changes to those files and remove them from the ATLAS folder completely. After this, we can look at Erin's PR #70 |
AL-255
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.