Open
Conversation
Contributor
Author
Hi @Nimok15, thanks for reviewing it. I've checked it and, indeed, it is using the base port as reference. I don't think it will have an issue with routing because the destination will move it to an absolute position, and layers are the same for all of them. However, I agree that it's not clean and is better using the right reference for the emitter. Thanks for noticing. By the way, I couldn't see your suggested change in the code itself, but I know what you meant and going to update the branch with a fix. Thanks, |
7167f77 to
ef9746d
Compare
Contributor
Author
ef9746d to
c7ead1e
Compare
c7ead1e to
284876a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to create any patter with an array of fets and do an automatic routing.
Based on custom patterning implemented for #50
Note: If required we can remove commits from BJT just to enclose for custom pattern