Refine demangler setting and execinfo use #1445
Open
+38
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1401 updated the detection for
execinfo.hby relying on a header-finding macro directly which is powerful. It also removed a set of#if defined(...)tests precluding several architectures from trying. This now bit us in issue #1442 as on FreeBSD, the header is found ... but also requires a library.Now, we could try to use autoconf to find header and library, and attempt to compile a test program (as we now do for OpenMP in RcppArmadillo and RcppEigen). But given that the affected architectures here are on the less-widely used side with difficult access for us to test and refine, a simpler strategy would be to punt and again rely on a set of
#if define()so this PR restores this. That is plain KISS Principle: Keep it Simple (and) Stupid.Checklist
R CMD checkstill passes all tests