3.0.0 #24
Merged
3.0.0 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made MessageHandler constructor private to further adhere to it being a singleton class.
Started cleaning up MessageHandler as well.
Moved CorePlayerListener#getSilentPrefix to Storage
Contributor
Author
|
#14 is going to be extremely difficult given the singleton nature of numerous crucial classes. Switching to dependency injection would be necessary for easier, cleaner, and generally more acceptable tests. DI is also considered recommended practice in virtually all situations. |
Leave dependent messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.