-
Notifications
You must be signed in to change notification settings - Fork 5.3k
添加了NXP MCXA346的UART demo #11120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
添加了NXP MCXA346的UART demo #11120
Conversation
|
|
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_mcxaReviewers: @hywing Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-01-05 14:16 CST)
📝 Review Instructions
|
|
|
||
| static rt_device_t tx_serial = RT_NULL; | ||
|
|
||
| /* 发送任务入口函数 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释部分编码不对
| /* end of CYW43439 WiFi */ | ||
| /* end of Wi-Fi */ | ||
| #define PKG_USING_AT_DEVICE | ||
| #define AT_DEVICE_USING_ESP8266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
保留最小即可,不需要添加这么多依赖
|
有冲突需要解决下 |
|
测评demo不建议提交上来,当然你可以优化一下,做成一个demo,通过在board/kconfig下添加一个宏定义配置项,相关源文件放到board/port/at_xxx/目录下,另外.config和rtconfig.h不建议被修改(默认保持工程的最小体量) |
|
demo的话需要参考下面的方式,对接到utest框架: https://github.com/RT-Thread/rt-thread/tree/master/bsp/k230/drivers/utest |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
NXPFRDM-MCXA346评测活动
你的解决方案是什么 (what is your solution)
添加UART3的驱动,完成esp8266的联网测试
请提供验证的bsp和config (provide the config and bsp)
CONFIG_RT_USING_SYSTEM_WORKQUEUE=y
CONFIG_RT_USING_SAL=y
CONFIG_RT_USING_AT=y
CONFIG_PKG_USING_AT_DEVICE=y
https://github.com/tm456-43/rt-thread/actions/runs/20706764588
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up