Get scalar from VRAM when using ROCm and large bar is enabled#3048
Open
pschlan-amd wants to merge 1 commit intoROCm:developfrom
Open
Get scalar from VRAM when using ROCm and large bar is enabled#3048pschlan-amd wants to merge 1 commit intoROCm:developfrom
pschlan-amd wants to merge 1 commit intoROCm:developfrom
Conversation
|
Jenkins build for 94e90632358dcd6435b90d94a8d0ac1f63e69fce commit finished as FAILURE |
|
Jenkins build for 94e90632358dcd6435b90d94a8d0ac1f63e69fce commit finished as FAILURE |
Author
Failures seem to also be reproducible without this patch, so probably unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When large BAR is enabled, we should be able to read scalars directly from VRAM and can skip the malloc + memcpy, reducing the latency.
Technical Details
Test Plan
Test Result
Submission Checklist