Remove code duplications in batched gemm wmma#3580
Merged
illsilin merged 5 commits intoROCm:developfrom Jan 23, 2026
Merged
Conversation
chris-tsiaousis-hpc
force-pushed
the
213-remove-code-duplications-in-batched-gemm-wmma
branch
2 times, most recently
from
35de4db to
c96ce10
Compare
chris-tsiaousis-hpc
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent,
vidyasagar-amd and
vpietila-amd
as code owners
Signed-off-by: Chris Tsiaousis <chris.tsiaousis@streamhpc.com>
…tation Signed-off-by: Chris Tsiaousis <chris.tsiaousis@streamhpc.com>
Signed-off-by: Chris Tsiaousis <chris.tsiaousis@streamhpc.com>
This change enables further code reduction by re-using the common structs for the batched gemm and batched gemm b scale wmma implementations. Signed-off-by: Chris Tsiaousis <chris.tsiaousis@streamhpc.com>
…ffleV3_Common" Signed-off-by: Chris Tsiaousis <chris.tsiaousis@streamhpc.com>
chris-tsiaousis-hpc
force-pushed
the
213-remove-code-duplications-in-batched-gemm-wmma
branch
from
961ceec to
49b278e
Compare
ErwinTerpstra
approved these changes
Jan 23, 2026
Contributor
ErwinTerpstra
left a comment
ErwinTerpstra
left a comment
There was a problem hiding this comment.
Review processed on internal repository.
illsilin
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is currently a lot of code duplication in the batch gemm device structs. We removed some duplications in the gemm structs by creating a common base struct which is used by the different flavors.
This PR uses a similar method to remove code duplications in batch gemm device structs.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed files