Skip to content

fix: remove carpet clean mode #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 1 commit into from
Feb 22, 2026
Merged

fix: remove carpet clean mode #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions roborock/data/v1/v1_clean_modes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class VacuumModes(RoborockModeEnum):
TURBO = ("turbo", 103)
MAX = ("max", 104)
MAX_PLUS = ("max_plus", 108)
CARPET = ("carpet", 107)
OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109)
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing VacuumModes.CARPET is a breaking public API change (this enum is re-exported from roborock and used by consumers). With the current semantic-release config, a fix: commit will not trigger a major bump, so this could ship as a minor/patch while breaking downstream code. Consider keeping CARPET as a deprecated alias (but omit it from get_clean_modes()), or change the release classification (e.g., refactor) and ensure the breaking change is clearly called out in the changelog.

Suggested change
OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109)
OFF_RAISE_MAIN_BRUSH = ("off_raise_main_brush", 109)
# Deprecated: kept as alias for backward compatibility with older public API
CARPET = OFF

Copilot uses AI. Check for mistakes.
CUSTOMIZED = ("custom", 106)
SMART_MODE = ("smart_mode", 110)
Expand Down Expand Up @@ -85,8 +84,6 @@ def get_clean_modes(features: DeviceFeatures) -> list[VacuumModes]:
if features.is_max_plus_mode_supported or features.is_none_pure_clean_mop_with_max_plus:
# If the vacuum has max plus mode supported
modes.append(VacuumModes.MAX_PLUS)
if features.is_carpet_deep_clean_supported:
modes.append(VacuumModes.CARPET)
if features.is_pure_clean_mop_supported:
# If the vacuum is capable of 'pure mop clean' aka no vacuum
if features.is_support_main_brush_up_down_supported:
Expand Down