Skip to content

fix tito#995

Draft
mikasenghaas wants to merge 3 commits intomainfrom
fix-tito
Draft

fix tito#995
mikasenghaas wants to merge 3 commits intomainfrom
fix-tito

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Mar 6, 2026

Description

from cluster

uv run vf-eval wiki-search -n1 -r1 -d -v -m zai-org/GLM-4.5-Air -b ... --api-client-type openai_chat_completions_token --disable-env-server 

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes

if prompt_ids != full_ids_with_env_response:
import difflib

from transformers import AutoTokenizer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for debug

self.logger.debug(
"TITO/MITO mismatch, falling back to MITO:\n%s", "".join(diff)
)
return None
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not return None, otherwise we get breaks also on retokenization discrepancy which is exactly what we not want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant