Open
Conversation
| // In reality, rewards are split by outcome probability. | ||
| const userShare = INVESTMENT_AMOUNT / (totalDepth + INVESTMENT_AMOUNT); | ||
| // Adjust reward by probability (approximate using price) | ||
| const outcomeRewardPool = dailyRewardPool * midPrice; |
There was a problem hiding this comment.
Bug: Reward pool allocation can exceed 100%
The calculation multiplies dailyRewardPool by midPrice for each outcome independently. Since midPrices across outcomes don't necessarily sum to 1.0 due to bid-ask spreads, the total allocated rewards across all outcomes can exceed the actual daily reward pool, making the reward estimates inaccurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a standalone TypeScript example for calculating liquidity rewards using additive spread logic.
Note
Adds a standalone TypeScript script and README to fetch market/order book data, sort bids/asks, compute additive-spread depth, and estimate daily rewards per outcome.
reward-calculation/calculate-rewards.ts):Gamma APIand order books fromCLOB API.clobTokenIds/outcomes, iterates outcomes, and computes mid-price from best bid/ask.bidsdesc,asksasc).rewardsDailyRate, investment amount, and mid-price weighting.reward-calculation/README.md):ts-node), and logic overview (sorting, additive spread, depth calculation).Written by Cursor Bugbot for commit 6ed7731. This will update automatically on new commits. Configure here.