-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update and add Pokemon evolutions #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…dd new min_damage_taken field for evolutions
|
There seems to be an issue with the k8s build step. I'm looking into this, but I don't see a reason for the error it's providing unless the |
|
From what I have seen, this k8s failure seems to happen a bit in other PRs even when other CI checks pass just fine (including other variants of the build checks). I'll re-open this PR for review then, but if this needs further attention let me know. |
|
Thanks for the pr! I'll check the build status |
|
Hi! Found out the issue!
Here I prepare the build data from the This seams the way: https://stackoverflow.com/questions/62694361/how-to-reference-a-local-volume-in-kind-kubernetes-in-docker I'll try in the next days and keep this PR open for testing. |
|
Ah ok, great! I'm glad to hear it was identified. Plus I'm glad it was something regarding the CI, as I was pretty sure my changes were working properly haha |
Added new evolution methods:
use-move: Pokemon that evolved by using a move (e.g. Annihilape and Overqwil in PLZA)three-defeated-bisharp: Method specific to Kingambitgimmighoul-coins: Method specific to GholdengoAdded new evolution method fields:
needs_multiplayer: Boolean flag that is false for all Pokemon aside from Palafinused_move_id: Move that must be used for the evolution to trigger. (e.g. Annihilape's Rage Fist or Wyrdeer's Psyshield Bash)min_move_count: Minimum number of times a move must be used for the evolution to trigger (e.g. 20 Barb Barrage for Overqwil in PLZA)min_steps: Minimum number of steps taken to trigger evolution (e.g. 1000 for Brambleghast)min_damage_taken: Minimum damage taken to trigger evolution (e.g. 49 for Runerigus and 249 for Basculegion)The evolution methods for the following Pokemon were changed:
min_damage_takenfield to 49other->use-movefor Rage Fist withmin_move_countset to 20agile-style-movemethod now usesused_move_idinstead ofknown_move_idfor clarity. Also setsmin_move_countto 20.min_damage_takenfield to 249strong-style-move: now usesused_move_idinstead ofknown_move_idfor clarity. Also setsmin_move_countto 20.level-upwithknown-moveset to Barb Barrageother->use-movefor Barb Barrage withmin_move_countset to 20other->three-defeated-bisharpother->level-upwithmin_stepsset to 1000other->level-upwithmin_stepsset to 1000other->level-upwithmin_stepsset to 1000other->level-upwithneeds_multiplayerset to trueother->gimmighoul-coinsOnly one Pokemon was left with
other: Maushold. Wasn't quite sure of a neat way to describe that it evolves only from battle experience randomly within your party. So the currentotherwithmin_levelset to 25 seemed reasonable. I am open to suggestions on that. All evolution information was taken from Serebii for a reputable source.I did test with a local build and found that things looked accurate, but let me know if anything was missed for a change like this as this is my first time adding new fields to something.