Skip to content

Conversation

@jemarq04
Copy link
Contributor

Added new evolution methods:

  • use-move: Pokemon that evolved by using a move (e.g. Annihilape and Overqwil in PLZA)
  • three-defeated-bisharp: Method specific to Kingambit
  • gimmighoul-coins: Method specific to Gholdengo

Added new evolution method fields:

  • needs_multiplayer: Boolean flag that is false for all Pokemon aside from Palafin
  • used_move_id: Move that must be used for the evolution to trigger. (e.g. Annihilape's Rage Fist or Wyrdeer's Psyshield Bash)
  • min_move_count: Minimum number of times a move must be used for the evolution to trigger (e.g. 20 Barb Barrage for Overqwil in PLZA)
  • min_steps: Minimum number of steps taken to trigger evolution (e.g. 1000 for Brambleghast)
  • min_damage_taken: Minimum damage taken to trigger evolution (e.g. 49 for Runerigus and 249 for Basculegion)

The evolution methods for the following Pokemon were changed:

  • Runerigus: Sets new min_damage_taken field to 49
  • Annihilape: other -> use-move for Rage Fist with min_move_count set to 20
  • Wyrdeer: The agile-style-move method now uses used_move_id instead of known_move_id for clarity. Also sets min_move_count to 20.
  • Basculegion: Sets new min_damage_taken field to 249
  • Overqwil:
    • PLA strong-style-move: now uses used_move_id instead of known_move_id for clarity. Also sets min_move_count to 20.
    • SV (newly added): Uses level-up with known-move set to Barb Barrage
    • PLZA other -> use-move for Barb Barrage with min_move_count set to 20
  • Kingambit: other -> three-defeated-bisharp
  • Pawmot: other -> level-up with min_steps set to 1000
  • Brambleghast: other -> level-up with min_steps set to 1000
  • Rabsca: other -> level-up with min_steps set to 1000
  • Palafin: other -> level-up with needs_multiplayer set to true
  • Gholdengo: other -> gimmighoul-coins

Only one Pokemon was left with other: Maushold. Wasn't quite sure of a neat way to describe that it evolves only from battle experience randomly within your party. So the current other with min_level set to 25 seemed reasonable. I am open to suggestions on that. All evolution information was taken from Serebii for a reputable source.

I did test with a local build and found that things looked accurate, but let me know if anything was missed for a change like this as this is my first time adding new fields to something.

@jemarq04 jemarq04 marked this pull request as draft December 31, 2025 19:40
@jemarq04
Copy link
Contributor Author

There seems to be an issue with the k8s build step. I'm looking into this, but I don't see a reason for the error it's providing unless the pokemon_evolution.csv file it is trying to use is not the one that I have updated.

@jemarq04
Copy link
Contributor Author

From what I have seen, this k8s failure seems to happen a bit in other PRs even when other CI checks pass just fine (including other variants of the build checks). I'll re-open this PR for review then, but if this needs further attention let me know.

@jemarq04 jemarq04 marked this pull request as ready for review December 31, 2025 21:56
@Naramsim
Copy link
Member

Naramsim commented Jan 1, 2026

Thanks for the pr! I'll check the build status

@Naramsim
Copy link
Member

Naramsim commented Jan 1, 2026

Hi! Found out the issue!

git clone --depth=1 --single-branch --branch=master --recurse-submodules --shallow-submodules https://github.com/PokeAPI/pokeapi.git &&

Here I prepare the build data from the master branch. I probably couldn't mount a volume in the k8s cluster and opted for this dirty way. I'll have to figure something out so to get the right data built in the k8s cluster.

This seams the way: https://stackoverflow.com/questions/62694361/how-to-reference-a-local-volume-in-kind-kubernetes-in-docker

I'll try in the next days and keep this PR open for testing.

@jemarq04
Copy link
Contributor Author

jemarq04 commented Jan 1, 2026

Ah ok, great! I'm glad to hear it was identified. Plus I'm glad it was something regarding the CI, as I was pretty sure my changes were working properly haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants