fix: Resolve Issue #54 and upgrade to Java 21 / Velocity 3.5.0#57
fix: Resolve Issue #54 and upgrade to Java 21 / Velocity 3.5.0#57Phoenix616 merged 3 commits intoPhoenix616:masterfrom
Conversation
|
Thanks for the PR! Not a fan of the readme/maven changes but I will fix thos myself before merge. |
There was a problem hiding this comment.
I'm unsure if Velocity's TabCompleteEvent should be forwarded like this. The issue here is that Velocity's TabCompleteEvent is fired when the backend server replies to a tab complete (what Bungee calls TabCompleteResponseEvent which is already forwarded), not when the player attempts to tab complete hence there is no good way to forward this event unfortunately.
I thought about doing this event the same way before, not sure why I didn't follow up on this, because when I think about it now I feel like this could at least make Bungee's TabCompleteEvent somewhat work instead of simply doing nothing (but it relies on the backend server replying, which only happens on 1.12.2 or below)
- Fixes that changing tab suggestions wouldn't work - Fix cases where sending the plugin message wouldn't work (as well as the future on login) - Fix `Player#isTransferred` not working - Move to numeric event priority instead of deprecated PostOrder
2 participants
Fixes #54
This PR modernizes the plugin to run natively on Java 21 and Velocity 3.5.0+.
It includes three main fixes:
ProxyServer#constructServerInfomethod not supported #54 Target Server Fix: Resolves crashes by using Velocity's native.constructServerInfoto ensureServerConnectEventalways has a valid target server.