Speed up load times of exporter #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening the exporter was wasting so much time in 2 lines
`self.oozPath = io.popen("cd"):read('*l'):gsub('\r?', '') .. "\\ggpk\\"`
Which opened a cmd windows to grab the current directory
and
`local datFiles = scanDir(self.oozPath .. "Data\\Balance\\", '%w+%.datc64$')`
which opened a cmd to scan the directory for the dat files we export
The first one is replaced with `GetWorkDir()`
and the second one is replaced with a lookup of the location from the list in `GetNeededFiles` 12 lines below
LocalIdentity
added
pob1
Wires77
approved these changes
Dec 17, 2025
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 17, 2025
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 17, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 17, 2025
* Apply changes from PathOfBuildingCommunity/PathOfBuilding-PoE2#1638 * Fix merge conflict --------- Co-authored-by: LocalIdentity <[email protected]> Co-authored-by: LocalIdentity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Opening the exporter was wasting so much time in 2 lines
self.oozPath = io.popen("cd"):read('*l'):gsub('\r?', '') .. "\\ggpk\\"Which opened a cmd windows to grab the current directory
and
local datFiles = scanDir(self.oozPath .. "Data\\Balance\\", '%w+%.datc64$')which opened a cmd to scan the directory for the dat files we export
The first one is replaced with
GetWorkDir()and the second one is replaced with a lookup of the location from the list in
GetNeededFiles12 lines belowBefore screenshot:
After screenshot: