[Feature] Support Norm before Rope. #6332
Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:developfrom Feb 5, 2026
Merged
Conversation
|
K11OntheBoat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
f478fb9 to
691d705
Compare
691d705 to
623ad9e
Compare
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6332 +/- ##
==========================================
Coverage ? 67.38%
==========================================
Files ? 389
Lines ? 51905
Branches ? 8082
==========================================
Hits ? 34976
Misses ? 14377
Partials ? 2552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sunny-bot1
approved these changes
Feb 5, 2026
K11OntheBoat
added a commit
that referenced
this pull request
Feb 5, 2026
* Support norm before rope * [Optimization] Accelerate Qwen3 QK RMSNorm via Fused Triton Kernel (#5880) * qk rmsnorm fused * inplace * glm * fix * add qknorm layer * fix * update * fix qwen3 vl * update rl baseline * fix qwen3 vl moe * test * fix qwen vl moe rl * fix * fix opt qknorm (#6080) * Support Norm before Rope * remove extra file --------- Co-authored-by: K11OntheBoat <“ruianmaidanglao@163.com”> Co-authored-by: sunxin <68891411+Sunny-bot1@users.noreply.github.com>
EmmonsCurse
added a commit
that referenced
this pull request
Feb 5, 2026
EmmonsCurse
added a commit
that referenced
this pull request
Feb 5, 2026
EmmonsCurse
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Support norm before rope * [Optimization] Accelerate Qwen3 QK RMSNorm via Fused Triton Kernel (#5880) * qk rmsnorm fused * inplace * glm * fix * add qknorm layer * fix * update * fix qwen3 vl * update rl baseline * fix qwen3 vl moe * test * fix qwen vl moe rl * fix * fix opt qknorm (#6080) * Support Norm before Rope * remove extra file --------- Co-authored-by: K11OntheBoat <“ruianmaidanglao@163.com”> Co-authored-by: sunxin <68891411+Sunny-bot1@users.noreply.github.com>
kesmeey
pushed a commit
to kesmeey/FastDeploy
that referenced
this pull request
Feb 22, 2026
Co-authored-by: K11OntheBoat <“ruianmaidanglao@163.com”>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
支持模型通过config变量来交换Attention之前的Rope和Norm计算顺序.
Modifications
支持模型通过config变量来交换Attention之前的Rope和Norm计算顺序.
Usage or Command
当config.json 中存在 "qk_norm_before_rope": true, 即可实现.
Accuracy Tests
结合具体模型评估
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.