Remove usage limiter check on API provisioning#4442
Open
Conversation
API provisioning (openfn project deploy) should be available to all plans. It's a core developer workflow tool, unlike GitHub Sync which is a premium automated integration feature. Closes OpenFn/thunderbolt#622
The #4426 entry documented adding `api_provisioning` action type which is now being removed. Net change for open source Lightning is zero since the default usage limiter stub always returns :ok.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4442 +/- ##
==========================================
+ Coverage 89.36% 89.40% +0.03%
==========================================
Files 425 425
Lines 20187 20185 -2
==========================================
+ Hits 18041 18047 +6
+ Misses 2146 2138 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@elias-ba fyi api privisioning and github sync are the same things, so I don't think the statement "GitHub Sync usage limiting remains unchanged." is valid. |
GitHub sync usage limits were incorrectly applied to all provisioning requests including CLI deploys. Now limits are only enforced when the actor is a RepoConnection.
Contributor
Author
|
@midigofrank thanks for the eagle eyes. This is a great catch. I implemented the fix you proposed in my last commit. Would you mind giving me another review ? Thanks dude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
limit_api_provisioningusage limiter check from the provisioning API. CLI project deploy (openfn project deploy) is no longer gated by usage limits. GitHub Sync usage limiting remains unchanged.Validation steps
Additional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)