Conversation
kindly
previously approved these changes
Nov 15, 2017
Contributor
kindly
left a comment
kindly
left a comment
There was a problem hiding this comment.
Can see how this would fix items of a single type, but they should really be expressed with minItems maxItems in the jsonschema.
We need to explain somewhere the limits to the subset of jsonschema we support.
We are not really supporting arrays with different types so my worry is that this pull request just pretends that we do.
However, happy to approve it for now.
Contributor
|
I think it would be better to simply error rather than pretend to support lists under |
ghost
changed the base branch from
|
@Bjwebb Given age, can this be closed? |
Member
|
@Bjwebb can this PR be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#180