Skip to content

[client] feat: add contract config type asset (#4302)#164

Merged
savacano28 merged 1 commit intomainfrom
issue/4302
Feb 12, 2026
Merged

[client] feat: add contract config type asset (#4302)#164
savacano28 merged 1 commit intomainfrom
issue/4302

Conversation

@savacano28
Copy link
Contributor

@savacano28 savacano28 commented Feb 11, 2026

Proposed changes

  • Add asset contract config type

Related issues

  • Closes #4302 ch 0

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

@savacano28 savacano28 requested a review from Megafredo February 12, 2026 09:19
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Feb 12, 2026
@savacano28 savacano28 self-assigned this Feb 12, 2026
Copy link
Member

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Megafredo not the new value, which you can use in your structured output, pending the upcoming, actual refactoring.

Changes incurred by this refactoring will only impact the shodan contracts with changing the "type" string.

There will be a backwards compatibilty layer which will allow us to defer this impact

@savacano28 savacano28 merged commit e043312 into main Feb 12, 2026
5 checks passed
@savacano28 savacano28 deleted the issue/4302 branch February 12, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants