Improve object creation of ItemStacks in the GUI class#24
Open
theEvilReaper wants to merge 2 commits intomasterfrom
Open
Improve object creation of ItemStacks in the GUI class#24theEvilReaper wants to merge 2 commits intomasterfrom
theEvilReaper wants to merge 2 commits intomasterfrom
Conversation
theEvilReaper
force-pushed
the
feature/improveGUI
branch
from
31d411e to
f251d08
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The implementation of the GUI is somewhat poor. It creates multiple instances of an ItemStack when only one instance is needed. Additionally, the logic has been split into different methods to improve maintainability.
Checklist