Merged
Conversation
KaloyanTanev
approved these changes
Jan 29, 2026
Collaborator
KaloyanTanev
left a comment
KaloyanTanev
left a comment
There was a problem hiding this comment.
Would it be possible to have a test case to catch this scenario?
Collaborator
Author
I was thinking about this, but let's wait for the full report and I suspect we may need to rework a lot more, including more of the tests... |
pinebit
force-pushed
the
pinebit/restore-key-fix
branch
from
715e7ec to
d9d0b24
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4261 +/- ##
==========================================
+ Coverage 56.54% 56.59% +0.04%
==========================================
Files 237 237
Lines 31471 31511 +40
==========================================
+ Hits 17796 17833 +37
- Misses 11397 11400 +3
Partials 2278 2278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aadomn
approved these changes
Feb 2, 2026
pinebit
added
the
do not merge
pinebit
force-pushed
the
pinebit/restore-key-fix
branch
from
a1dbb17 to
d4f4ae9
Compare
|
pinebit
added
merge when ready
KaloyanTanev
pushed a commit
that referenced
this pull request
Feb 10, 2026
This fixes a bug in `restoreKey` routine that affects "remove operators" edit command. category: bug ticket: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
restoreKeyroutine that affects "remove operators" edit command.category: bug
ticket: none