#3907 automatic change requests updating roles#3965
Open
cielbellerose wants to merge 19 commits intodevelopfrom
Open
#3907 automatic change requests updating roles#3965cielbellerose wants to merge 19 commits intodevelopfrom
cielbellerose wants to merge 19 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements automatic change requests for updating leads and managers of projects and work packages. Instead of requiring manual approval, leadership changes are now automatically approved and immediately applied. This streamlines the process of assigning or changing project and work package leadership.
Changes:
- Adds a new "Leadership" change request type that is auto-approved when created
- Implements frontend logic to detect when only leadership fields have changed and triggers automatic CR creation
- Adds backend service, controller, and database schema for leadership change requests
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/src/types/change-request-types.ts | Adds Leadership change request type and interface definitions |
| src/frontend/src/utils/urls.ts | Adds URL endpoint for leadership CR creation |
| src/frontend/src/utils/enum-pipes.ts | Adds text transformation for Leadership CR type |
| src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx | Implements leadership-only change detection and automatic CR submission for work packages |
| src/frontend/src/pages/WorkPackageForm/WorkPackageForm.tsx | Passes leadership CR creation function to form view |
| src/frontend/src/pages/WorkPackageForm/EditWorkPackageForm.tsx | Adds leadership CR hook and passes to form |
| src/frontend/src/pages/WorkPackageForm/CreateWorkPackageForm.tsx | Provides no-op leadership CR function (not applicable for new work packages) |
| src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectForm.tsx | Updates button states based on leadership-only changes |
| src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectEditContainer.tsx | Implements leadership-only change detection and automatic CR submission for projects |
| src/frontend/src/hooks/change-requests.hooks.ts | Adds React hook for creating leadership change requests |
| src/frontend/src/apis/change-requests.api.ts | Adds API function for leadership CR creation |
| src/backend/src/transformers/change-requests.transformer.ts | Updates transformers to include leadership CR lead/manager fields |
| src/backend/src/services/change-requests.services.ts | Implements service methods to create and apply leadership change requests |
| src/backend/src/routes/change-requests.routes.ts | Adds route for leadership CR creation |
| src/backend/src/prisma/schema.prisma | Adds Leadership_CR model and CR_Type enum value |
| src/backend/src/prisma/migrations/20260223001543_leadership_cr/migration.sql | Database migration for leadership CR table |
| src/backend/src/prisma-query-args/change-requests.query-args.ts | Includes leadership CR in query arguments |
| src/backend/src/controllers/change-requests.controllers.ts | Adds controller method for leadership CR creation |
Comments suppressed due to low confidence (1)
src/frontend/src/hooks/change-requests.hooks.ts:244
- Typo: "Custome" should be "Custom"
* Custome React hook to create a leadership change request
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectForm.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectForm.tsx
Outdated
Show resolved
Hide resolved
chpy04
requested changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updating a lead/manager of a project or work package is now an automatic change request
also supports removing lead/manager
Button Logic
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3907