Skip to content

#3907 automatic change requests updating roles#3965

Open
cielbellerose wants to merge 19 commits intodevelopfrom
#3907-automatic-change-requests-updating-roles
Open

#3907 automatic change requests updating roles#3965
cielbellerose wants to merge 19 commits intodevelopfrom
#3907-automatic-change-requests-updating-roles

Conversation

@cielbellerose
Copy link
Contributor

@cielbellerose cielbellerose commented Feb 10, 2026

Changes

Updating a lead/manager of a project or work package is now an automatic change request

also supports removing lead/manager

Button Logic

  • Submit button
    • Disabled when: no changes, or more than just leadership-only change
    • Enabled when: leadership-only changed (auto CR)
  • Create Change Request button
    • always enabled including when only leadership changed - logic was user can still make a formal CR if they want, but submit also works

Screenshots

Screenshot 2026-03-07 at 9 20 44 AM Screenshot 2026-03-07 at 9 56 33 AM Screenshot 2026-03-07 at 11 29 38 AM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3907

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements automatic change requests for updating leads and managers of projects and work packages. Instead of requiring manual approval, leadership changes are now automatically approved and immediately applied. This streamlines the process of assigning or changing project and work package leadership.

Changes:

  • Adds a new "Leadership" change request type that is auto-approved when created
  • Implements frontend logic to detect when only leadership fields have changed and triggers automatic CR creation
  • Adds backend service, controller, and database schema for leadership change requests

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/shared/src/types/change-request-types.ts Adds Leadership change request type and interface definitions
src/frontend/src/utils/urls.ts Adds URL endpoint for leadership CR creation
src/frontend/src/utils/enum-pipes.ts Adds text transformation for Leadership CR type
src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx Implements leadership-only change detection and automatic CR submission for work packages
src/frontend/src/pages/WorkPackageForm/WorkPackageForm.tsx Passes leadership CR creation function to form view
src/frontend/src/pages/WorkPackageForm/EditWorkPackageForm.tsx Adds leadership CR hook and passes to form
src/frontend/src/pages/WorkPackageForm/CreateWorkPackageForm.tsx Provides no-op leadership CR function (not applicable for new work packages)
src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectForm.tsx Updates button states based on leadership-only changes
src/frontend/src/pages/ProjectDetailPage/ProjectForm/ProjectEditContainer.tsx Implements leadership-only change detection and automatic CR submission for projects
src/frontend/src/hooks/change-requests.hooks.ts Adds React hook for creating leadership change requests
src/frontend/src/apis/change-requests.api.ts Adds API function for leadership CR creation
src/backend/src/transformers/change-requests.transformer.ts Updates transformers to include leadership CR lead/manager fields
src/backend/src/services/change-requests.services.ts Implements service methods to create and apply leadership change requests
src/backend/src/routes/change-requests.routes.ts Adds route for leadership CR creation
src/backend/src/prisma/schema.prisma Adds Leadership_CR model and CR_Type enum value
src/backend/src/prisma/migrations/20260223001543_leadership_cr/migration.sql Database migration for leadership CR table
src/backend/src/prisma-query-args/change-requests.query-args.ts Includes leadership CR in query arguments
src/backend/src/controllers/change-requests.controllers.ts Adds controller method for leadership CR creation
Comments suppressed due to low confidence (1)

src/frontend/src/hooks/change-requests.hooks.ts:244

  • Typo: "Custome" should be "Custom"
 * Custome React hook to create a leadership change request

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cielbellerose cielbellerose requested a review from chpy04 March 7, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - automatic change requests for updating leads and managers

3 participants