feat: add stats tracking for pacote.extract #618
+36
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 468dd7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clemgbld
reviewed
Jan 30, 2026
clemgbld
reviewed
Jan 30, 2026
workspaces/tarball/src/tarball.ts
Outdated
| }; | ||
| } | ||
|
|
||
| type ExtractFunction = ( |
Member
There was a problem hiding this comment.
i would rename it PacoteProvider and use an interface with the method extract
clemgbld
reviewed
Jan 30, 2026
clemgbld
reviewed
Jan 30, 2026
workspaces/scanner/src/depWalker.ts
Outdated
| pacoteProvider: { | ||
| extract: async(spec: string, dest: string, opts: pacote.Options) => { | ||
| await statsCollector.track( | ||
| `pacote.extract[${spec}]`, |
Member
There was a problem hiding this comment.
pacote.extract[${spec}] -> pacote.extract ${spec}
It’s the same pattern in the two other examples
clemgbld
reviewed
Jan 30, 2026
7amed3li
force-pushed
the
feat/stats-tracking-pacote-extract
branch
from
02daaed to
3483f28
Compare
clemgbld
reviewed
Jan 30, 2026
workspaces/scanner/src/depWalker.ts
Outdated
|
|
||
| const pacoteProvider: PacoteProvider = { | ||
| extract: async(spec, dest, opts) => { | ||
| await statsCollector.track( |
Member
There was a problem hiding this comment.
You don’t need the async await syntax since you don’t need the awaited result in this function
clemgbld
reviewed
Jan 30, 2026
clemgbld
reviewed
Jan 30, 2026
| spec: string, | ||
| destination: string, | ||
| options: pacote.Options | ||
| ): Promise<any>; |
Member
There was a problem hiding this comment.
The retuned type should be the same returned type than pacote.extract or void but not any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lightweight stats tracking for
pacote.extractby injecting a tracked extract function.This helps identify slow package extractions and potential bottlenecks during scans.
No breaking changes - existing code works as-is.
Closes #615