Skip to content

Improve resolve() typing#59

Merged
RobertoPrevato merged 3 commits intoNeoteroi:mainfrom
sobolevn:patch-4
Mar 8, 2026
Merged

Improve resolve() typing#59
RobertoPrevato merged 3 commits intoNeoteroi:mainfrom
sobolevn:patch-4

Conversation

@sobolevn
Copy link
Contributor

Using Union[Type[T], str] is problematic, because when str is passed, mypy infers T to be Never. Instead, you should use an overload with two cases, so inference would be correct:

from typing import Any, TypeVar, Union, Type, overload

T = TypeVar('T')

class My:
    def resolve(  # type: ignore[empty-body]
        self,
        obj_type: Union[Type[T], str],
    ) -> T:
        ...   # in reallity we would return something here
        
reveal_type(My().resolve(int))
# N: Revealed type is "builtins.int"
reveal_type(My().resolve('a'))
# N: Revealed type is "Never"

class Other:
    @overload
    def resolve(self, obj_type: Type[T]) -> T: ...
    @overload
    def resolve(self, obj_type: str) -> Any: ...
    def resolve(self, obj_type: Any) -> Any: ...

reveal_type(Other().resolve(int))
# N: Revealed type is "builtins.int"
reveal_type(Other().resolve('a'))
# N: Revealed type is "Any"

Link: https://mypy-play.net/?mypy=latest&python=3.12&gist=97dd0c638b48950199067e8290e5595e&flags=strict

This way users can actually use Any type, while Never type cannot be used for literally anything.

@RobertoPrevato RobertoPrevato merged commit ba7ab21 into Neoteroi:main Mar 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants