-
Notifications
You must be signed in to change notification settings - Fork 620
Fix minimum version of cublas for grouped gemm #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Pawel Gadzinski <[email protected]>
|
/te-ci |
Greptile OverviewGreptile SummaryThis PR corrects the minimum cuBLAS version requirement for grouped GEMM from 13.1.0 to 13.2.0, fixing build failures introduced in PR #2502. Changes:
Issue Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User Code
participant API as nvte_grouped_gemm
participant Check as Version Check
participant cuBLAS as cuBLAS 13.2+
User->>API: Call nvte_grouped_gemm()
API->>Check: Verify CUBLAS_VERSION >= 130200
alt Compile-time check fails
Check-->>User: Error: Requires cuBLAS 13.2+
else Compile-time check passes
API->>Check: Verify runtime cublas_version() >= 130200
alt Runtime check fails
Check-->>User: Error: Runtime cuBLAS too old
else Runtime check passes
API->>Check: Verify SM arch >= 100 (Blackwell)
alt Architecture check fails
Check-->>User: Error: Requires Blackwell or newer
else All checks pass
API->>cuBLAS: Execute grouped GEMM
cuBLAS-->>API: Result
API-->>User: Success
end
end
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
|
/te-ci jax L0 |
Signed-off-by: Pawel Gadzinski <[email protected]>
|
/te-ci pytorch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
| NVTE_CHECK(transformer_engine::cuda::sm_arch(current_device) >= 100, | ||
| "nvte_grouped_gemm requires Blackwell (SM100) or newer architecture."); | ||
| NVTE_CHECK(cuda::cublas_version() >= 130200, | ||
| NVTE_CHECK(transformer_engine::cuda::cublas_version() >= 130200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't there be more than one places to add this transformer_engine::?
|
/te-ci |
1 similar comment
|
/te-ci |
Signed-off-by: Pawel Gadzinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
Signed-off-by: Pawel Gadzinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 3 comments
Signed-off-by: Pawel Gadzinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Signed-off-by: Pawel Gadzinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
| cudaStream_t stream) { | ||
| NVTE_ERROR("nvte_grouped_gemm requires cuBLAS 13.1+, but compile-time cuBLAS version is ", | ||
| NVTE_ERROR("nvte_grouped_gemm requires cuBLAS 13.2+, but compile-time cuBLAS version is ", | ||
| CUBLAS_VERSION, ". Please upgrade to CUDA 13.1 or newer."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error message says "upgrade to CUDA 13.1 or newer" but should say "CUDA 13.2 or newer" to match the cuBLAS 13.2+ requirement
| CUBLAS_VERSION, ". Please upgrade to CUDA 13.1 or newer."); | |
| CUBLAS_VERSION, ". Please upgrade to CUDA 13.2 or newer."); |
Description
Fixes build issue introduced with #2502 - that PR had incorrect minimal version of cublas and it results in build fails on some containers.
Type of change
Checklist: