Dev 0.2.1 new browser session

[LeoLiang000]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @LeoLiang000, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural refactor to the browser management system, moving from a singleton-like Driver and a basic BrowserSessionManager to a more robust BrowserSessionPool. This change centralizes the creation, acquisition, and release of browser sessions, allowing for more efficient resource management and improved scalability for parallel test execution. The updates ensure that all dependent components correctly integrate with the new pooled session approach, leading to a more stable and performant testing framework.

Highlights

• Browser Session Pooling: A new BrowserSessionPool has been implemented to manage browser instances, enabling efficient reuse and parallel execution of tests. This replaces the previous BrowserSessionManager.
• Decoupled Browser Management: The dedicated Driver class has been removed. BrowserSession (now internally _BrowserSession) directly handles Playwright browser lifecycle, simplifying the architecture and reducing indirection.
• Enhanced Parallel Test Execution: The ParallelTestExecutor now utilizes the BrowserSessionPool to acquire and release browser sessions, improving resource utilization and test stability, especially for concurrent test runs.
• Streamlined Action Handling: The ActionHandler and UITester classes have been updated to interact directly with the BrowserSession's page object, removing the intermediate Driver layer and simplifying code paths.
• Performance Test Session Handling: A specific PERFORMANCE_TEST_NO_SESSION_ID has been introduced to correctly identify performance tests that do not require a dedicated browser session from the pool, as they manage their own browser instances.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant and valuable refactoring of the browser session management by replacing the Driver and BrowserSessionManager with a more robust BrowserSessionPool. This is an excellent architectural improvement that enhances efficiency and concurrency handling. My review focuses on a few critical areas within this new implementation to ensure its stability and correctness. I've identified a bug in the cookie handling logic, a potential race condition in the session recovery mechanism, and an issue with how cancelled test sessions are handled, which is crucial for maintaining session integrity in a parallel execution environment. The provided suggestions aim to fortify the new session pooling logic.

[gemini-code-assist]

This is a good change to release the session back to the pool. However, there's a related issue: when a test is cancelled, browser_failed is not set to True in the except asyncio.CancelledError: block (around line 270). This means a cancelled session will be released as 'healthy', which is unsafe as its state is unknown and could cause subsequent tests to fail.

To fix this, you should add browser_failed = True at the beginning of the except asyncio.CancelledError: block.

References

1. The parallel test executor must correctly manage the state of browser sessions, especially when tests are cancelled. Releasing an unhealthy session as healthy could lead to subsequent tests, potentially with different configurations, failing due to a corrupted session state. This aligns with the rule that the executor should support running tests with different browser configurations within the same test session, as reliable session management is foundational for this capability.