Add source generator for input map names.#37
Open
OmerCanDanacioglu wants to merge 1 commit intoMattParkerDev:mainfrom
Open
Add source generator for input map names.#37OmerCanDanacioglu wants to merge 1 commit intoMattParkerDev:mainfrom
OmerCanDanacioglu wants to merge 1 commit intoMattParkerDev:mainfrom
Conversation
Owner
|
Hi, thanks for raising this! I think for now I would prefer to not add our own source generator to do this - it isn't that much effort updating the InputStringNames :) And I believe godot may be adding this functionality OOTB at some point :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduce the InputMapNameConstants class in SharpIDE.SourceGenerators/InputMapName. It defines constants used for source generation of input action string names in the Godot project.
Main purpose is to get rid of the boilerplate code when creating a new input mapping from Godot - Input Mappings.
With this change, source generator code should read from project.godot file to generate input mappings.