Skip to content

rust: Fix query formatting for pgwire#35201

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-sql-formatting-minimal
Feb 26, 2026
Merged

rust: Fix query formatting for pgwire#35201
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-sql-formatting-minimal

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 24, 2026

Minimal alternative to #35191
We can merge this first, whether we want to merge the other or not.

@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- marked this pull request as ready for review February 24, 2026 16:56
@def- def- requested review from a team as code owners February 24, 2026 16:56
@def- def- requested review from aljoscha and martykulma February 24, 2026 17:31
@def-
Copy link
Contributor Author

def- commented Feb 26, 2026

Ready for review

@def- def- force-pushed the pr-sql-formatting-minimal branch from 19e3c17 to b3e5901 Compare February 26, 2026 09:45
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(Btw. the PR description says "Minimal alternative to #35198", but that PR is already merged, so maybe you meant to link a different PR?)

@def- def- force-pushed the pr-sql-formatting-minimal branch from b3e5901 to 3c5a76b Compare February 26, 2026 14:23
@def-
Copy link
Contributor Author

def- commented Feb 26, 2026

Thanks, fixed: #35191

@def- def- enabled auto-merge (squash) February 26, 2026 14:23
@def- def- merged commit 8963e3f into MaterializeInc:main Feb 26, 2026
135 checks passed
@def- def- deleted the pr-sql-formatting-minimal branch February 26, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants