Skip to content

controller: Add some missing doc comments#35012

Merged
ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay:instance_client-refactoring-3
Feb 17, 2026
Merged

controller: Add some missing doc comments#35012
ggevay merged 1 commit intoMaterializeInc:mainfrom
ggevay:instance_client-refactoring-3

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Feb 13, 2026 •
edited
Loading

Resolves some of the /// TODO(database-issues#7533): Add documentation. comments in controller/error.rs.

Part 3 of 3 from the original #34839. (Does not depend on the other 2 PRs.)

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@ggevay ggevay mentioned this pull request Feb 13, 2026
Closed
@ggevay ggevay marked this pull request as ready for review February 13, 2026 22:01
@ggevay ggevay requested a review from a team as a code owner February 13, 2026 22:01
teskje
teskje approved these changes Feb 17, 2026
View reviewed changes
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggevay ggevay merged commit 5a0e6db into MaterializeInc:main Feb 17, 2026
134 checks passed
patrickwwbutler pushed a commit to patrickwwbutler/materialize that referenced this pull request Feb 19, 2026
@ggevay @patrickwwbutler
controller: Add some missing doc comments (MaterializeInc#35012)
b0e1249 
Resolves some of the `/// TODO(database-issues#7533): Add
documentation.` comments in `controller/error.rs`.

Part 3 of 3 from the original MaterializeInc#34839. (Does _not_ depend on the other 2
PRs.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teskje teskje teskje approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggevay @teskje