expr: extend #[sqlfunc] to variadic functions and convert all eager variadics#34985

Open

antiguru wants to merge 33 commits intoMaterializeInc:mainfrom

antiguru:variadic_func

Member

antiguru commented Feb 12, 2026 •

edited

Loading

Add the EagerVariadicFunc trait with a blanket LazyVariadicFunc implementation, and extend the #[sqlfunc] proc macro to generate EagerVariadicFunc implementations for variadic functions.
Convert all 30 eager variadic functions from hand-written dispatch to #[sqlfunc]-derived implementations, then extend derive_variadic! to generate the full VariadicFunc dispatch.

Best viewed commit-by-commit.

🤖 Generated with Claude Code

github-actions bot commented Feb 12, 2026

Pre-merge checklist

The PR title is descriptive and will make sense in the git log.
This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

antiguru force-pushed the variadic_func branch 2 times, most recently from 6c22a17 to e9ed7e2 Compare

February 19, 2026 13:02

antiguru force-pushed the variadic_func branch from d59427b to ac8fb59 Compare

February 26, 2026 19:08

antiguru changed the title ~~expr: refactor VariadicFunc to trait-based dispatch with typed inputs~~ expr: extend #[sqlfunc] to variadic functions and convert all eager variadics

antiguru requested a review from ggevay

February 26, 2026 20:30

antiguru marked this pull request as ready for review

February 26, 2026 20:30

antiguru requested a review from a team as a code owner

February 26, 2026 20:30

antiguru commented

View reviewed changes

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

antiguru force-pushed the variadic_func branch from ac8fb59 to d59427b Compare

February 26, 2026 22:06

antiguru requested a review from a team as a code owner

February 26, 2026 22:06

antiguru force-pushed the variadic_func branch 4 times, most recently from 5013ece to 7553d9a Compare

February 27, 2026 12:16

antiguru and others added 15 commits

February 27, 2026 13:57


          expr: add EagerVariadicFunc trait and extend #[sqlfunc] for variadic …

fdf33cd

…functions

Add the `EagerVariadicFunc` trait and a blanket `LazyVariadicFunc`
implementation that bridges eager evaluation with the existing lazy
dispatch. Extend the `#[sqlfunc]` proc macro to generate
`EagerVariadicFunc` implementations for variadic functions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert Replace to #[sqlfunc]

3d10411

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert Translate to #[sqlfunc]

cd27d46

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert Concat to #[sqlfunc]

6b5deba

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ConcatWs to #[sqlfunc]

c293108

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert SplitPart to #[sqlfunc]

f57367f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert Substr to #[sqlfunc]

21de597

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert DateDiffDate to #[sqlfunc]

2cc7e1f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert DateDiffTime to #[sqlfunc]

b8b62ec

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert DateDiffTimestamp and DateDiffTimestampTz to #[sqlfunc]

aef6348

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert HmacString and HmacBytes to #[sqlfunc]

f495b74

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert PadLeading to #[sqlfunc]

f682aa0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert DateBinTimestamp, DateBinTimestampTz, and TimezoneTime …

69c0971

…to #[sqlfunc]

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert MakeAclItem to #[sqlfunc]

397b7d3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert MakeMzAclItem to #[sqlfunc]

adab023

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>

antiguru and others added 16 commits

February 27, 2026 13:57


          expr: convert MakeTimestamp to #[sqlfunc]

71a290d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert RegexpReplace to #[sqlfunc]

ab03be9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert JsonbBuildObject to #[sqlfunc]

76b30d7

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert JsonbBuildArray to #[sqlfunc]

fe90ab5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayPosition to #[sqlfunc]

23c9c4c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert RegexpMatch to #[sqlfunc]

062f0e6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert RegexpSplitToArray to #[sqlfunc]

deccce1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert StringToArray to #[sqlfunc]

305e911

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ListIndex to #[sqlfunc]

81e3306

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ListSliceLinear to #[sqlfunc]

e538d92

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayFill to #[sqlfunc]

c3137e0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert ArrayIndex to #[sqlfunc]

ea048c2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayToString to #[sqlfunc]

b11fd19

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert MapBuild to #[sqlfunc]

89b163a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ListCreate and RecordCreate to #[sqlfunc]

03df1be

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayCreate to #[sqlfunc]

0edc612

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>

antiguru force-pushed the variadic_func branch from 7553d9a to 078bc59 Compare

February 27, 2026 13:03

antiguru and others added 2 commits

February 27, 2026 14:12


          expr: generate VariadicFunc dispatch via derive_variadic! macro

d8e336e

Extend `derive_variadic!` to generate the full `impl VariadicFunc`
block (eval, output_type, propagates_nulls, introduces_nulls,
could_error, is_monotone, is_associative, is_infix_op) by delegating
to `LazyVariadicFunc` trait methods. Remove the hand-written dispatch
that duplicated per-variant logic. Convert `RangeCreate` to
`EagerVariadicFunc`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          doc: add developer guide for #[sqlfunc] macro

d695205

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

antiguru force-pushed the variadic_func branch from 078bc59 to d695205 Compare

February 27, 2026 13:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet