Skip to content

Conversation

@mgree
Copy link
Contributor

@mgree mgree commented Jan 21, 2026

Change ColumnKnowledge to use repr types.

Motivation

Tips for reviewer

We can drop the cases of the if because they cannot occur---ReprScalarTypes don't have meaningful modifiers.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@mgree mgree requested a review from a team as a code owner January 21, 2026 20:51
@mgree mgree added A-sql Area: SQL planning A-optimization Area: query optimization and transformation labels Jan 21, 2026
@mgree mgree assigned ggevay and unassigned ggevay Jan 21, 2026
@mgree mgree requested a review from ggevay January 21, 2026 21:05
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mgree mgree merged commit caea874 into MaterializeInc:main Jan 28, 2026
133 checks passed
ggevay added a commit to ggevay/materialize that referenced this pull request Jan 29, 2026
ggevay added a commit that referenced this pull request Jan 29, 2026
Revert "[repr types] Convert ColumnKnowledge transform (#34788)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-optimization Area: query optimization and transformation A-sql Area: SQL planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants