[repr types] Convert ColumnKnowledge transform #34788
Merged
+889
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ColumnKnowledge to use repr types.
Motivation
https://github.com/MaterializeInc/database-issues/issues/10016#issuecomment-3779135166
design doc: MIR typechecking using representation types #27239
Tips for reviewer
We can drop the cases of the if because they cannot occur---
ReprScalarTypes don't have meaningful modifiers.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.