MDEV-21543: use bitwise & to fix build error on amd64-msan-clang-20-debug#4707
Open
MohamedM216 wants to merge 1 commit intoMariaDB:mainfrom
Open
MDEV-21543: use bitwise & to fix build error on amd64-msan-clang-20-debug#4707MohamedM216 wants to merge 1 commit intoMariaDB:mainfrom
& to fix build error on amd64-msan-clang-20-debug#4707MohamedM216 wants to merge 1 commit intoMariaDB:mainfrom
Conversation
Member
grooverdan
approved these changes
Feb 27, 2026
grooverdan
approved these changes
Mar 2, 2026
gkodinov
added
the
External Contribution
gkodinov
approved these changes
Mar 2, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for working on this. This is a preliminary review.
Please add a commit message to your commit so that it complies with CODING_STANDARDS.md.
And please keep working with Daniel on his review.
Contributor
Author
|
Thanks @gkodinov for your feedback. This PR only fixes #4625, so I think the current commit message is sufficient and already complies with the 72-character limit specified in CODING_STANDARDS.md. Additionally, since there is only a single commit, there isn’t any commit history to revise. Please let me know if you would still prefer a more detailed commit message and how you would like it to be. |
Member
|
Recommendation on commit message: |
…ns (fix) Correct compilation on clang-20 by using a bitwise & rather than the incorrect &&.
MohamedM216
force-pushed
the
MDEV-21543/fix-pr-4625
branch
from
0a76cc9 to
121d13f
Compare
Contributor
Author
|
Updated. Thanks! |
grooverdan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue: MDEV-21543