MDEV-37842 Fix CHANGE_MASTER_TO warning message#4702
Open
gengtianuiowa wants to merge 1 commit intoMariaDB:10.11from
Open
MDEV-37842 Fix CHANGE_MASTER_TO warning message#4702gengtianuiowa wants to merge 1 commit intoMariaDB:10.11from
gengtianuiowa wants to merge 1 commit intoMariaDB:10.11from
Conversation
When `master_use_gtid` is set to no in the master database and the user runs `CHANGE MASTER TO master_use_gtid= NO;`, the server will print following warning: ``` Note 4190 CHANGE MASTER TO is implicitly changing the value of 'Using_Gtid' from 'No' to 'No' ``` This is because the code only checks if the new value is "NO", regardless if the original value is also no. Change the if statement to only print the message when the original value is not "No".
gengtianuiowa
force-pushed
the
fix_change_master_to
branch
from
0c5dfcb to
fd0156f
Compare
|
|
gkodinov
added
the
External Contribution
gkodinov
requested changes
Feb 27, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
There's already work going on for this MDEV. See PR#4678. Please do not duplicate.
I suggest closing this PR and finding something else that is not already in progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
master_use_gtidis set to no in the master database and the user runsCHANGE MASTER TO master_use_gtid= NO;, the server will print following warning:This is because the code only checks if the new value is "NO", regardless if the original value is also no.
Change the if statement to only print the message when the original value is not "No".
How can this PR be tested?
Execute the
rpl.rpl_change_master_use_gtid_no_warningtest in mysql-test-run. This commit adds a test inrpl_change_master_use_gtid_no_warning.test.Basing the PR against the correct MariaDB version
Backward compatibility
This is a warning message fix. It is compatible with previous versions.
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.