Fixed NumberLine get_number_mobjects() and get_labels()#4638
Open
BillyLjm wants to merge 2 commits intoManimCommunity:mainfrom
Open
Fixed NumberLine get_number_mobjects() and get_labels()#4638BillyLjm wants to merge 2 commits intoManimCommunity:mainfrom
BillyLjm wants to merge 2 commits intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Closes issue #2473, fixes
NumberLine.get_number_mobjects()and the adjacentNumberLine.get_labels().Motivation and Explanation: Why and how do your changes improve the library?
NumberLine.get_number_mobjects()used an unimplemented function and would a throw an error if used. This simply fixes it to use the return the mobject of all ticks in the number line.NumberLine.get_labels()did not return the same thing asNumberLine.add_labels()which seems like a bug. So I fixed it to returnself.labels, and default to the existing implementation if the attribute is not accessible.Links to added or changed documentation pages
None
Further Information and Comments
None
Reviewer Checklist