refactor: split MAAValue into MAAValue and ResolvedMAAValue#485
Open
refactor: split MAAValue into MAAValue and ResolvedMAAValue#485
MAAValue into MAAValue and ResolvedMAAValue#485Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @wangl-cc, your pull request is larger than the review limit of 150000 diff characters
Member
Author
|
@copilot review |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
===========================================
- Coverage 70.48% 17.14% -53.35%
===========================================
Files 61 2 -59
Lines 5825 175 -5650
Branches 5825 175 -5650
===========================================
- Hits 4106 30 -4076
+ Misses 1408 144 -1264
+ Partials 311 1 -310 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request refactors the maa-value crate to introduce a type-safe distinction between unresolved configuration templates and fully resolved values. The refactoring improves API clarity by splitting MAAValue into two distinct types and reorganizes the codebase into a more modular structure.
Changes:
- Split
MAAValueintoMAAValue(unresolved) andResolvedMAAValue(resolved) types to enforce type safety - Rename
init()method toresolve()to better reflect the transformation from unresolved to resolved state - Modularize codebase by extracting functionality into dedicated modules (
array,convert,map,value,error) and introduce traits (MapOps,ArrayOps,AsPrimitive,TryAs) for improved ergonomics - Add
maa_value::preludemodule for convenient imports - Update all dependent crates (
maa-cli,maa-value-macro) to adapt to the new API
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/maa-value/src/value.rs | Defines MAAValue and ResolvedMAAValue enums with resolve() method and conversion implementations |
| crates/maa-value/src/map.rs | Introduces MapOps trait with map-like operations (get, insert, merge, join) for both value types |
| crates/maa-value/src/convert.rs | Defines AsPrimitive and TryAs traits with conversion macros for primitive types |
| crates/maa-value/src/array.rs | Introduces ArrayOps trait for array-like operations |
| crates/maa-value/src/primitive.rs | Updates MAAPrimitive type with simplified implementation using conversion traits |
| crates/maa-value/src/lib.rs | Refactors to export modules and adds prelude with common imports |
| crates/maa-value/src/input.rs | Updates import paths to use new module structure |
| crates/maa-value/src/userinput/*.rs | Updates import paths for error module |
| crates/maa-value-macro/src/*.rs | Updates codegen to use fully qualified paths for new module structure |
| crates/maa-value-macro/tests/*.rs | Updates all tests to use resolve() instead of init() and import from prelude |
| crates/maa-cli/src/**/*.rs | Updates to use ResolvedMAAValue type and call resolve() on unresolved values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…AValue` Refactors the `maa-value` crate to distinguish between configuration templates (which may contain user inputs and conditional logic) and fully resolved values. Key changes: - Split `MAAValue` into `MAAValue` (unresolved) and `ResolvedMAAValue` (resolved) to enforce type safety. - Rename `init()` method to `resolve()` to better reflect the transformation process. - Modularize `maa-value` source code by extracting logic into `array`, `convert`, `map`, `value`, and `error` modules. - Introduce `MapOps`, `ArrayOps`, `AsPrimitive`, and `TryAs` traits to standardize operations and improve ergonomics. - Add `maa_value::prelude` for convenient imports. - Update `maa-cli` and `maa-value-macro` to adapt to the API changes and new type definitions.
wangl-cc
force-pushed
the
refactor/resolved_maa_value
branch
from
02f6f8d to
3e4febe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
maa-valuecrate to distinguish between configuration templates (which may contain user inputs and conditional logic) and fully resolved values.Key changes:
MAAValueintoMAAValue(unresolved) andResolvedMAAValue(resolved) to enforce type safety.init()method toresolve()to better reflect the transformation process.maa-valuesource code by extracting logic intoarray,convert,map,value, anderrormodules.MapOps,ArrayOps,AsPrimitive, andTryAstraits to standardize operations and improve ergonomics.maa_value::preludefor convenient imports.maa-cliandmaa-value-macroto adapt to the API changes and new type definitions.