-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(ui): fix dashboard search spaces layout for 1024px and below #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): fix dashboard search spaces layout for 1024px and below #662
Conversation
|
@melvnl is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by RecurseML
🔍 Review performed on 7360938..c5b31bb
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/app/dashboard/searchspaces/page.tsx
|
@melvnl Reduce the font size in mobile view as well. |
|
@AnishSarkar22 I assume you’re referring to the “Create Search Space” heading, right? I agree, on smaller phones it can feel a bit overwhelming. I noticed that other pages use responsive styles like text-xl md:text-3xl or text-2xl md:text-3xl, so I’ll align with that and go with text-2xl md:text-3xl here |
|
Yeah please, thank you. |
|
I've updated the PR, let me know if there's anything else |
|
@AnishSarkar22 Can you review this and LMK if its good to merge? |
|
@MODSetter Yes its good to merge. Good job @melvnl |
Description
This PR fixes responsiveness issues on the Dashboard → Search Spaces page, particularly for screen widths 1024px and below.
The layout previously broke due to container width constraints, causing content to appear cramped or misaligned on tablets and small laptops. The updated layout ensures a consistent and usable experience across breakpoints.
Motivation and Context
The issue was caused by the use of Tailwind’s container utility in an app-style layout.
The container class applies breakpoint-based max-width constraints (including a hard limit at 1024px), which led to unintended layout compression and content misalignment on tablet and small laptop screens.
This change replaces the problematic container usage with more explicit width and padding control, making the layout responsive and predictable across viewport sizes while preserving the intended desktop appearance.
FIX #645
Screenshots / Videos
BEFORE:
https://github.com/user-attachments/assets/010d6c58-43a9-4ff8-86d1-b061c6f70ae5
AFTER:
https://github.com/user-attachments/assets/4a23a1ff-53a6-442b-81f2-8bc91a7aea90
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR fixes a responsive layout issue on the Dashboard Search Spaces page for screen widths at or below 1024px. The fix replaces Tailwind's
containerutility class, which applies breakpoint-based max-width constraints causing layout compression on tablets and small laptops, with explicit width and padding controls (max-w-5xl px-4 py-6 lg:py-10). This ensures consistent and usable layout across all viewport sizes while maintaining the intended desktop appearance.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/app/dashboard/searchspaces/page.tsx