Skip to content

Conversation

@melvnl
Copy link
Contributor

@melvnl melvnl commented Jan 2, 2026

Description

This PR fixes responsiveness issues on the Dashboard → Search Spaces page, particularly for screen widths 1024px and below.
The layout previously broke due to container width constraints, causing content to appear cramped or misaligned on tablets and small laptops. The updated layout ensures a consistent and usable experience across breakpoints.

Motivation and Context

The issue was caused by the use of Tailwind’s container utility in an app-style layout.
The container class applies breakpoint-based max-width constraints (including a hard limit at 1024px), which led to unintended layout compression and content misalignment on tablet and small laptop screens.

This change replaces the problematic container usage with more explicit width and padding control, making the layout responsive and predictable across viewport sizes while preserving the intended desktop appearance.

FIX #645

Screenshots / Videos

BEFORE:
https://github.com/user-attachments/assets/010d6c58-43a9-4ff8-86d1-b061c6f70ae5

AFTER:
https://github.com/user-attachments/assets/4a23a1ff-53a6-442b-81f2-8bc91a7aea90

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation
  • Dependency/Build system
  • Breaking change
  • Other (specify):

Testing Performed

  • Tested locally
  • Manual/QA verification

Checklist

  • Follows project coding standards and conventions
  • Documentation updated as needed
  • Dependencies updated as needed
  • No lint/build errors or new warnings
  • All relevant tests are passing

High-level PR Summary

This PR fixes a responsive layout issue on the Dashboard Search Spaces page for screen widths at or below 1024px. The fix replaces Tailwind's container utility class, which applies breakpoint-based max-width constraints causing layout compression on tablets and small laptops, with explicit width and padding controls (max-w-5xl px-4 py-6 lg:py-10). This ensures consistent and usable layout across all viewport sizes while maintaining the intended desktop appearance.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_web/app/dashboard/searchspaces/page.tsx

Need help? Join our Discord

Analyze latest changes

@vercel
Copy link

vercel bot commented Jan 2, 2026

@melvnl is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@recurseml recurseml bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 7360938..c5b31bb

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (1)

surfsense_web/app/dashboard/searchspaces/page.tsx

@AnishSarkar22
Copy link
Contributor

@melvnl Reduce the font size in mobile view as well.

@melvnl
Copy link
Contributor Author

melvnl commented Jan 2, 2026

@AnishSarkar22 I assume you’re referring to the “Create Search Space” heading, right? I agree, on smaller phones it can feel a bit overwhelming. I noticed that other pages use responsive styles like text-xl md:text-3xl or text-2xl md:text-3xl, so I’ll align with that and go with text-2xl md:text-3xl here

@AnishSarkar22
Copy link
Contributor

Yeah please, thank you.

@melvnl
Copy link
Contributor Author

melvnl commented Jan 2, 2026

I've updated the PR, let me know if there's anything else

@MODSetter
Copy link
Owner

@AnishSarkar22 Can you review this and LMK if its good to merge?

@AnishSarkar22
Copy link
Contributor

AnishSarkar22 commented Jan 3, 2026

@MODSetter Yes its good to merge. Good job @melvnl

@MODSetter MODSetter merged commit d7899ea into MODSetter:main Jan 3, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Create Search Space page is not mobile UI friendly

3 participants