Merged
Conversation
Pull Request Test Coverage Report for Build 21631760475Details
💛 - Coveralls |
jazairi
approved these changes
Feb 2, 2026
Contributor
jazairi
left a comment
There was a problem hiding this comment.
Nice and straightforward straightforward, thanks to the Feature model. 🙂 I considered requesting additional test coverage, but I don't think there's much to test just yet. (The Feature model is already well covered.) My sense is that we can update the suite once we do more with this in the normalizers.
Thanks for updating the cassettes!
Why are these changes being introduced: * Searching full text when available is expected to return additional relevant results when available metadata does expose terms used to search Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-294 How does this address that need: * Adds a feature to enable fulltext searching of timdex indexes * Updates GraphQL query to search fulltext when feature is enabled Document any side effects to this change: * Updates GraphQL to add perPage value which is not fully implemented in this ticket. I added this now to hopefully minimize the amount of cassettes that will need to be regenerated when we fully implement that feature
1ccbc43 to
e8cabb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing