Skip to content

Query TIMDEX fulltext if feature enabled#351

Merged
JPrevost merged 1 commit intomainfrom
use-294-timdex-fulltext
Feb 3, 2026
Merged

Query TIMDEX fulltext if feature enabled#351
JPrevost merged 1 commit intomainfrom
use-294-timdex-fulltext

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Jan 29, 2026

Why are these changes being introduced:

  • Searching full text when available is expected to return additional relevant results when available metadata does expose terms used to search

Relevant ticket(s):

How does this address that need:

  • Adds a feature to enable fulltext searching of timdex indexes
  • Updates GraphQL query to search fulltext when feature is enabled

Document any side effects to this change:

  • Updates GraphQL to add perPage value which is not fully implemented in this ticket. I added this now to hopefully minimize the amount of cassettes that will need to be regenerated when we fully implement that feature

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Jan 29, 2026

Pull Request Test Coverage Report for Build 21631760475

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 98.12%

Totals Coverage Status
Change from base Build 21486807924: 0.001%
Covered Lines: 1305
Relevant Lines: 1330

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-294-ti-xwjqhn January 29, 2026 14:24 Inactive
@jazairi jazairi self-assigned this Feb 2, 2026
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and straightforward straightforward, thanks to the Feature model. 🙂 I considered requesting additional test coverage, but I don't think there's much to test just yet. (The Feature model is already well covered.) My sense is that we can update the suite once we do more with this in the normalizers.

Thanks for updating the cassettes!

Why are these changes being introduced:

* Searching full text when available is expected to return additional relevant results when available metadata does expose terms used to search

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-294

How does this address that need:

* Adds a feature to enable fulltext searching of timdex indexes
* Updates GraphQL query to search fulltext when feature is enabled

Document any side effects to this change:

* Updates GraphQL to add perPage value which is not fully implemented in this ticket. I added this now to hopefully minimize the amount of cassettes that will need to be regenerated when we fully implement that feature
@JPrevost JPrevost force-pushed the use-294-timdex-fulltext branch from 1ccbc43 to e8cabb0 Compare February 3, 2026 13:17
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-294-ti-xwjqhn February 3, 2026 13:18 Inactive
@JPrevost JPrevost merged commit 80a4d04 into main Feb 3, 2026
5 checks passed
@JPrevost JPrevost deleted the use-294-timdex-fulltext branch February 3, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments