Open
Conversation
Author
|
Friendly ping. |
Contributor
|
This certainly requires further investigation. The solution provided may not work in a speculative trace environment as the m_last_IS var is only used to update the context element at the time the single context packet is seen and before it is added to the element stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For decoding ETM with thumb mode, we should also update the
m_last_ISvalue from the instruction decoder.Otherwise, the decoded ISA might be incorrect when handling the later context/atom element.
It might reflect an incorrect A32/T32 ISA.