Skip to content

Conversation

@jlnav
Copy link
Member

@jlnav jlnav commented Jan 15, 2026

No description provided.

@jlnav jlnav marked this pull request as ready for review January 21, 2026 17:18
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.65%. Comparing base (ba9a9ef) to head (5cbc999).

❗ There is a different number of reports uploaded between BASE (ba9a9ef) and HEAD (5cbc999). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (ba9a9ef) HEAD (5cbc999)
18 12
Additional details and impacted files
@@                            Coverage Diff                             @@
##           experimental/jlnav_plus_shuds_asktell    #1656       +/-   ##
==========================================================================
- Coverage                                  58.01%   47.65%   -10.37%     
==========================================================================
  Files                                         80       80               
  Lines                                       8127     8127               
  Branches                                    1235     1235               
==========================================================================
- Hits                                        4715     3873      -842     
- Misses                                      3130     4034      +904     
+ Partials                                     282      220       -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlnav jlnav requested review from jmlarson1 and shuds13 January 21, 2026 17:52
.. _gpcam: https://gpcam.lbl.gov/
.. _paper: https://link.springer.com/article/10.1007/s12532-017-0131-4

.. _Expected Improvement: https://github.com/xopt-org/Xopt/blob/v3.0/xopt/generators/bayesian/expected_improvement.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know if these branches are persistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely not - I'll have it point to the valid main-branch path

Xopt - https://github.com/xopt-org/Xopt
---------------------------------------

`Expected Improvement`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could state as examples.

@jlnav jlnav requested a review from shuds13 January 29, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants