-
Notifications
You must be signed in to change notification settings - Fork 54
Feat/tpcc dual #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tpcc dual #302
Conversation
|
|
||
| if last_keys.as_ref() != Some(&group_keys) { | ||
| last_keys = Some(group_keys.clone()); | ||
| co.yield_(Ok(Tuple::new(None, group_keys))).await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lost PrimaryKey
|
|
||
| if let ScalarExpression::Constant(value) = arg_expr.as_ref() { | ||
| let casted = value.clone().cast(ty)?; | ||
| let _ = mem::replace(expr, ScalarExpression::Constant(casted)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace it first to avoid copying values
tpcc/src/backend/dual.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
What problem does this PR solve?
feat:
fix:
Code changes
Check List
Tests
Side effects
Note for reviewer