Skip to content

Conversation

@KKould
Copy link
Member

@KKould KKould commented Jan 17, 2026

What problem does this PR solve?

feat:

  • A Dual parameter has been added to compare results between KiteSQL and SQLite in-memory mode in TPCC to verify the correctness of the results (the default is to run for only 60 seconds).
  • Add StreamDistinct to leverage the ordered options of the upstream schedule for efficient deduplication(Similar to SortElimination).
  • The ConstantCalculator has been optimized by directly rewriting Cast Constant as Constant.

fix:

  • Fixed an issue where incorrect results were caused by the primary key index still using index cover.

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer


if last_keys.as_ref() != Some(&group_keys) {
last_keys = Some(group_keys.clone());
co.yield_(Ok(Tuple::new(None, group_keys))).await;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost PrimaryKey


if let ScalarExpression::Constant(value) = arg_expr.as_ref() {
let casted = value.clone().cast(ty)?;
let _ = mem::replace(expr, ScalarExpression::Constant(casted));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace it first to avoid copying values

}
}

#[cfg(test)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@KKould KKould self-assigned this Jan 17, 2026
@KKould KKould added the enhancement New feature or request label Jan 17, 2026
@KKould KKould merged commit fa4473f into main Jan 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants