add first prototype of texElementImage2D#3752
Draft
cabanier wants to merge 2 commits intoKhronosGroup:mainfrom
Draft
add first prototype of texElementImage2D#3752cabanier wants to merge 2 commits intoKhronosGroup:mainfrom
cabanier wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
kenrussell
reviewed
Dec 16, 2025
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
One initial comment. Likely this PR will remain unmerged for a while until there are prototype implementations of this new API. In the meantime, progress can be made on the API's semantics, addressing the TBD mentioned here, etc.
specs/latest/2.0/index.html
Outdated
| <p>The width and height of the texture are derived from the CSS width and height of the element at the time of rendering. Add links to whatwg.</p> | ||
| <p>TBD: define state of rendering + security. These will be more links to whatwg</p><p></p> | ||
| <p>If no WebGLBuffer is bound to the <code>PIXEL_PACK_BUFFER</code> target, generates an | ||
| <code>INVALID_OPERATION</code> error.</p> |
Member
There was a problem hiding this comment.
This validation related to PIXEL_PACK_BUFFER looks reversed; if a buffer's bound to that target then the textures' contents come from it. I think that instead this should say "If a WebGLBuffer is bound...", since the goal is for the texture's contents to come from the rendered element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @kenrussell