Test uploading individual LOD levels to 3D textures from images#3699
Test uploading individual LOD levels to 3D textures from images#3699Jimbly wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
|
Notes:
|
| if (useMinMax) { | ||
| // Note: this seems like it should work, but fails on uint textures, | ||
| // bug in test / test author, or bug in implementations? | ||
| gl.texParameterf(bindingTarget, gl.TEXTURE_MIN_LOD, lod); |
There was a problem hiding this comment.
Using TEXTURE_MIN/MAX_LOD here works in all tests except for the unsigned integer formats (where it appears to sample from the wrong level). I'm not sure if that means there's something I don't understand, or if I've stumbled upon a bug. I'd be happy to change this code to also test the alternative way to choose which lod levels are sampled from, or to remove this (currently unreachable) branch if desired.
|
Anything required to get this merged or anything I can do to help move the process along? |
|
Hi, apologies for dropping this on the floor. It's been on my plate to study, potentially simplify, and debug this test case for a while. Have pulled this up in my to-do list. The test passes in Firefox and Safari and fails in Chrome, indicating a bug in Chrome's texture upload path. |
|
Thanks, good to hear! That is the same results I saw in my testing. Let me know if there's anything I can do to help. Unfortunately the bug doesn't happen unless the textures are over a certain size, and sourced from an IMG element, and targeting an LOD level, so there's probably not a ton that can be simplified (though my unfamiliarity with the testing framework probably left room for improvement, as well as the unknowns I commented on ^_^). |
See:
https://issues.chromium.org/issues/40910322