Disallow point rendering with undefined point size#3356
Closed
lexaknyazev wants to merge 2 commits intoKhronosGroup:mainfrom
Closed
Disallow point rendering with undefined point size#3356lexaknyazev wants to merge 2 commits intoKhronosGroup:mainfrom
lexaknyazev wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
kenrussell
reviewed
Nov 18, 2021
| </p> | ||
| <div class="note rationale"> | ||
| <p> | ||
| Point rendering with undefined point size is undefined in GLES and may be unsupported in other APIs. |
Member
There was a problem hiding this comment.
From concall: please mention something more precise about why this doesn't work.
Member
Author
There was a problem hiding this comment.
After looking into this again, it seems there are two underlying issues there:
- D3D11 does not support point rendering with point size greater than
1.0, so ANGLE generates a geometry shader to handle that. - The presence of
gl_PointSizein the original ESSL source non-trivially affects ANGLE's shader translator (e.g., how varyings are packed), so simply prepending all shaders withgl_PointSize = 1.0;may cause unexpected issues. Those may be caused by unknown bugs in the translator.
So this issue looks like an ANGLE limitation, which may remain indefinitely.
What would be the appropriate language for the spec here?
kenrussell
reviewed
Nov 18, 2021
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Yes, it would be ideal to update the conformance tests at the same time.
kenrussell
requested changes
Dec 2, 2021
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
@lexaknyazev is it feasible for you to make the requested changes?
Contributor
|
Just so this doesn't get lost, I'm not sure this should happen. See #2822 (comment) |
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Dec 4, 2021
Failing to set this was relying on currently-undefined behavior and causing the tests to fail on Apple's M1. Related to KhronosGroup#2818, KhronosGroup#2822 and KhronosGroup#3356.
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Dec 4, 2021
Failing to set this was relying on currently-undefined behavior and causing the tests to fail on Apple's M1. Related to KhronosGroup#2818, KhronosGroup#2822 and KhronosGroup#3356.
kdashg
pushed a commit
that referenced
this pull request
Dec 6, 2021
Member
Author
|
Closed in favor of #3370. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2818.
Should the CTS update be included in this PR before merging?