Fix A8-on-R8 swizzle test on Chrome#2819
Fix A8-on-R8 swizzle test on Chrome#2819kenrussell merged 1 commit intoKhronosGroup:masterfrom lexaknyazev:fix-texture-active-bind-test
Conversation
kdashg
left a comment
kdashg
left a comment
There was a problem hiding this comment.
gl_PointSize is only valid when positive (and within ALIASED_POINT_SIZE_RANGE), so setting gl_PointSize shouldn't matter here, as it would be unsafe for WebGL to treat these as undefined.
WebGL doesn't specify what happens if gl_PointSize is unset, but gl_PointSize should always be being clamped to within the point size range, which does not allow zero.
Also, transform feedback with needs to run on drawArrays(POINTS) regardless of gl_Position or gl_PointSize, so skipping the draw (which is what it sounds like is happening?) here would be invalid.
|
I think that this particular test (active vs bound texture) shouldn't depend on an unrelated implementation issue that could be resolved separately. |
GLES doesn't suggest that (from 3.0 section 3.4):
|
|
I filed #2822 to add an explicit test for this. |
|
Let's talk about this in that PR, but I generally don't like working around implementation bugs in unrelated tests. |
|
To keep coverage, I would like to resolve #2822 before merging this. |
conformance/textures/misc/texture-active-bind.html was fixed on Windows in KhronosGroup/WebGL#2819 LUMINANCE/ALPHA emulation fixes in http://crrev.com/c/1545512 fixed these tests on Android Qualcomm: conformance2/textures/misc/tex-new-formats.html conformance2/textures/misc/copy-texture-image-luma-format.html deqp/functional/gles3/textureformat/unsized_2d_array.html deqp/functional/gles3/textureformat/unsized_3d.html TBR: kbr@chromium.org Bug: 931006, 906740, 947236 Change-Id: I5c3a79c17b6a263b1a52f0a9fa646de591e370b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559756 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#649767}
3 participants
Fixes this test on Chrome due to #2818.